Support dark mode #684

lenemter · 2023-09-02T10:49:12Z

Fixes #688
Closes #563
Closes #499

To do:

Deduplicate objects
More testing

BAProductions · 2023-09-02T13:03:40Z

Close my commit well

src/PantheonAccountsServicePlugin.vala

danirabbit

🚀

danirabbit · 2024-01-31T00:16:13Z

Testing this with the latest settings-daemon, I am now getting a blank screen on the greeter 😬 Does this need to be updated too?

lenemter · 2024-01-31T00:18:49Z

That's weird. Have you installed elementary/wingpanel#499 by any chance? If you have, try uninstalling it.

lenemter · 2024-02-03T10:37:57Z

I fixed a bug that prevented setting user preferences, everything should work as expected now.

danirabbit · 2024-02-05T17:32:43Z

Sorry for taking a while to respond! Just tried again on a relatively clean OS 8 install where I have not had that wingpanel branch and I'm still getting a blank/gray screen with this branch. So it seems like the compositor is probably loading but not the panel or greeter window

lenemter · 2024-02-08T05:19:54Z

@danirabbit Not sure what might have caused that. Can you send me logs from /var/log/lightdm/seat0-greeter.log please?

danirabbit · 2024-02-13T18:09:45Z

@lenemter sorry for taking a while to follow up!

(io.elementary.greeter:39487): GLib-CRITICAL **: 10:02:05.863: g_variant_new_string: assertion 'string != NULL' failed

(io.elementary.greeter:39487): GLib-CRITICAL **: 10:02:05.863: g_variant_ref_sink: assertion 'value != NULL' failed

(io.elementary.greeter:39487): GLib-CRITICAL **: 10:02:05.863: g_variant_ref_sink: assertion 'value != NULL' failed

(io.elementary.greeter:39487): GLib-GIO-CRITICAL **: 10:02:05.863: g_settings_schema_key_type_check: assertion 'value != NULL' failed

(io.elementary.greeter:39487): GLib-CRITICAL **: 10:02:05.863: g_variant_get_type_string: assertion 'value != NULL' failed

(io.elementary.greeter:39487): GLib-GIO-CRITICAL **: 10:02:05.863: g_settings_set_value: key 'document-font-name' in 'org.gnome.desktop.interface' expects type 's', but a GVariant of type '(null)' was given

(io.elementary.greeter:39487): GLib-CRITICAL **: 10:02:05.863: g_variant_unref: assertion 'value != NULL' failed

(io.elementary.greeter:39487): GLib-CRITICAL **: 10:02:05.865: g_variant_new_string: assertion 'string != NULL' failed

(io.elementary.greeter:39487): GLib-CRITICAL **: 10:02:05.865: g_variant_ref_sink: assertion 'value != NULL' failed

(io.elementary.greeter:39487): GLib-CRITICAL **: 10:02:05.865: g_variant_ref_sink: assertion 'value != NULL' failed

(io.elementary.greeter:39487): GLib-GIO-CRITICAL **: 10:02:05.865: g_settings_schema_key_type_check: assertion 'value != NULL' failed

(io.elementary.greeter:39487): GLib-CRITICAL **: 10:02:05.865: g_variant_get_type_string: assertion 'value != NULL' failed

(io.elementary.greeter:39487): GLib-GIO-CRITICAL **: 10:02:05.865: g_settings_set_value: key 'font-name' in 'org.gnome.desktop.interface' expects type 's', but a GVariant of type '(null)' was given

(io.elementary.greeter:39487): GLib-CRITICAL **: 10:02:05.865: g_variant_unref: assertion 'value != NULL' failed

(io.elementary.greeter:39487): GLib-CRITICAL **: 10:02:05.866: g_variant_new_string: assertion 'string != NULL' failed

(io.elementary.greeter:39487): GLib-CRITICAL **: 10:02:05.866: g_variant_ref_sink: assertion 'value != NULL' failed

(io.elementary.greeter:39487): GLib-CRITICAL **: 10:02:05.866: g_variant_ref_sink: assertion 'value != NULL' failed

(io.elementary.greeter:39487): GLib-GIO-CRITICAL **: 10:02:05.866: g_settings_schema_key_type_check: assertion 'value != NULL' failed

(io.elementary.greeter:39487): GLib-CRITICAL **: 10:02:05.866: g_variant_get_type_string: assertion 'value != NULL' failed

(io.elementary.greeter:39487): GLib-GIO-CRITICAL **: 10:02:05.866: g_settings_set_value: key 'monospace-font-name' in 'org.gnome.desktop.interface' expects type 's', but a GVariant of type '(null)' was given

(io.elementary.greeter:39487): GLib-CRITICAL **: 10:02:05.866: g_variant_unref: assertion 'value != NULL' failed

** (io.elementary.greeter:39487): CRITICAL **: 10:02:05.879: MainWindow.vala:350: prompt: `Password: ' (1)

** (io.elementary.greeter:39487): CRITICAL **: 10:02:06.698: MainWindow.vala:350: prompt: `Password: ' (1)

(io.elementary.greeter:39487): GLib-CRITICAL **: 10:02:07.364: g_variant_new_string: assertion 'string != NULL' failed

(io.elementary.greeter:39487): GLib-CRITICAL **: 10:02:07.364: g_variant_ref_sink: assertion 'value != NULL' failed

(io.elementary.greeter:39487): GLib-CRITICAL **: 10:02:07.364: g_variant_ref_sink: assertion 'value != NULL' failed

(io.elementary.greeter:39487): GLib-GIO-CRITICAL **: 10:02:07.364: g_settings_schema_key_type_check: assertion 'value != NULL' failed

(io.elementary.greeter:39487): GLib-CRITICAL **: 10:02:07.364: g_variant_get_type_string: assertion 'value != NULL' failed

(io.elementary.greeter:39487): GLib-GIO-CRITICAL **: 10:02:07.364: g_settings_set_value: key 'document-font-name' in 'org.gnome.desktop.interface' expects type 's', but a GVariant of type '(null)' was given

(io.elementary.greeter:39487): GLib-CRITICAL **: 10:02:07.364: g_variant_unref: assertion 'value != NULL' failed

(io.elementary.greeter:39487): GLib-CRITICAL **: 10:02:07.367: g_variant_new_string: assertion 'string != NULL' failed

(io.elementary.greeter:39487): GLib-CRITICAL **: 10:02:07.367: g_variant_ref_sink: assertion 'value != NULL' failed

(io.elementary.greeter:39487): GLib-CRITICAL **: 10:02:07.367: g_variant_ref_sink: assertion 'value != NULL' failed

(io.elementary.greeter:39487): GLib-GIO-CRITICAL **: 10:02:07.367: g_settings_schema_key_type_check: assertion 'value != NULL' failed

(io.elementary.greeter:39487): GLib-CRITICAL **: 10:02:07.367: g_variant_get_type_string: assertion 'value != NULL' failed

(io.elementary.greeter:39487): GLib-GIO-CRITICAL **: 10:02:07.367: g_settings_set_value: key 'font-name' in 'org.gnome.desktop.interface' expects type 's', but a GVariant of type '(null)' was given

(io.elementary.greeter:39487): GLib-CRITICAL **: 10:02:07.367: g_variant_unref: assertion 'value != NULL' failed

(io.elementary.greeter:39487): GLib-CRITICAL **: 10:02:07.369: g_variant_new_string: assertion 'string != NULL' failed

(io.elementary.greeter:39487): GLib-CRITICAL **: 10:02:07.369: g_variant_ref_sink: assertion 'value != NULL' failed

(io.elementary.greeter:39487): GLib-CRITICAL **: 10:02:07.369: g_variant_ref_sink: assertion 'value != NULL' failed

(io.elementary.greeter:39487): GLib-GIO-CRITICAL **: 10:02:07.369: g_settings_schema_key_type_check: assertion 'value != NULL' failed

(io.elementary.greeter:39487): GLib-CRITICAL **: 10:02:07.369: g_variant_get_type_string: assertion 'value != NULL' failed

(io.elementary.greeter:39487): GLib-GIO-CRITICAL **: 10:02:07.369: g_settings_set_value: key 'monospace-font-name' in 'org.gnome.desktop.interface' expects type 's', but a GVariant of type '(null)' was given

(io.elementary.greeter:39487): GLib-CRITICAL **: 10:02:07.369: g_variant_unref: assertion 'value != NULL' failed

** (io.elementary.greeter:39487): CRITICAL **: 10:02:07.379: MainWindow.vala:350: prompt: `Password: ' (1)

** (io.elementary.greeter:39487): CRITICAL **: 10:02:08.084: MainWindow.vala:350: prompt: `Password: ' (1)

(io.elementary.greeter:39487): GLib-CRITICAL **: 10:02:08.866: g_variant_new_string: assertion 'string != NULL' failed

(io.elementary.greeter:39487): GLib-CRITICAL **: 10:02:08.866: g_variant_ref_sink: assertion 'value != NULL' failed

(io.elementary.greeter:39487): GLib-CRITICAL **: 10:02:08.866: g_variant_ref_sink: assertion 'value != NULL' failed

(io.elementary.greeter:39487): GLib-GIO-CRITICAL **: 10:02:08.866: g_settings_schema_key_type_check: assertion 'value != NULL' failed

(io.elementary.greeter:39487): GLib-CRITICAL **: 10:02:08.866: g_variant_get_type_string: assertion 'value != NULL' failed

(io.elementary.greeter:39487): GLib-GIO-CRITICAL **: 10:02:08.866: g_settings_set_value: key 'document-font-name' in 'org.gnome.desktop.interface' expects type 's', but a GVariant of type '(null)' was given

(io.elementary.greeter:39487): GLib-CRITICAL **: 10:02:08.866: g_variant_unref: assertion 'value != NULL' failed

(io.elementary.greeter:39487): GLib-CRITICAL **: 10:02:08.868: g_variant_new_string: assertion 'string != NULL' failed

(io.elementary.greeter:39487): GLib-CRITICAL **: 10:02:08.868: g_variant_ref_sink: assertion 'value != NULL' failed

(io.elementary.greeter:39487): GLib-CRITICAL **: 10:02:08.868: g_variant_ref_sink: assertion 'value != NULL' failed

(io.elementary.greeter:39487): GLib-GIO-CRITICAL **: 10:02:08.868: g_settings_schema_key_type_check: assertion 'value != NULL' failed

(io.elementary.greeter:39487): GLib-CRITICAL **: 10:02:08.868: g_variant_get_type_string: assertion 'value != NULL' failed

(io.elementary.greeter:39487): GLib-GIO-CRITICAL **: 10:02:08.868: g_settings_set_value: key 'font-name' in 'org.gnome.desktop.interface' expects type 's', but a GVariant of type '(null)' was given

(io.elementary.greeter:39487): GLib-CRITICAL **: 10:02:08.868: g_variant_unref: assertion 'value != NULL' failed

(io.elementary.greeter:39487): GLib-CRITICAL **: 10:02:08.878: g_variant_new_string: assertion 'string != NULL' failed

(io.elementary.greeter:39487): GLib-CRITICAL **: 10:02:08.878: g_variant_ref_sink: assertion 'value != NULL' failed

(io.elementary.greeter:39487): GLib-CRITICAL **: 10:02:08.878: g_variant_ref_sink: assertion 'value != NULL' failed

(io.elementary.greeter:39487): GLib-GIO-CRITICAL **: 10:02:08.878: g_settings_schema_key_type_check: assertion 'value != NULL' failed

(io.elementary.greeter:39487): GLib-CRITICAL **: 10:02:08.878: g_variant_get_type_string: assertion 'value != NULL' failed

(io.elementary.greeter:39487): GLib-GIO-CRITICAL **: 10:02:08.878: g_settings_set_value: key 'monospace-font-name' in 'org.gnome.desktop.interface' expects type 's', but a GVariant of type '(null)' was given

(io.elementary.greeter:39487): GLib-CRITICAL **: 10:02:08.878: g_variant_unref: assertion 'value != NULL' failed

** (io.elementary.greeter:39487): CRITICAL **: 10:02:08.886: MainWindow.vala:350: prompt: `Password: ' (1)

** (io.elementary.greeter:39487): CRITICAL **: 10:02:09.767: MainWindow.vala:350: prompt: `Password: ' (1)

(io.elementary.greeter:39487): GLib-CRITICAL **: 10:02:10.550: g_variant_new_string: assertion 'string != NULL' failed

(io.elementary.greeter:39487): GLib-CRITICAL **: 10:02:10.550: g_variant_ref_sink: assertion 'value != NULL' failed

(io.elementary.greeter:39487): GLib-CRITICAL **: 10:02:10.550: g_variant_ref_sink: assertion 'value != NULL' failed

(io.elementary.greeter:39487): GLib-GIO-CRITICAL **: 10:02:10.550: g_settings_schema_key_type_check: assertion 'value != NULL' failed

(io.elementary.greeter:39487): GLib-CRITICAL **: 10:02:10.550: g_variant_get_type_string: assertion 'value != NULL' failed

(io.elementary.greeter:39487): GLib-GIO-CRITICAL **: 10:02:10.550: g_settings_set_value: key 'document-font-name' in 'org.gnome.desktop.interface' expects type 's', but a GVariant of type '(null)' was given

(io.elementary.greeter:39487): GLib-CRITICAL **: 10:02:10.550: g_variant_unref: assertion 'value != NULL' failed

(io.elementary.greeter:39487): GLib-CRITICAL **: 10:02:10.551: g_variant_new_string: assertion 'string != NULL' failed

(io.elementary.greeter:39487): GLib-CRITICAL **: 10:02:10.552: g_variant_ref_sink: assertion 'value != NULL' failed

(io.elementary.greeter:39487): GLib-CRITICAL **: 10:02:10.552: g_variant_ref_sink: assertion 'value != NULL' failed

(io.elementary.greeter:39487): GLib-GIO-CRITICAL **: 10:02:10.552: g_settings_schema_key_type_check: assertion 'value != NULL' failed

(io.elementary.greeter:39487): GLib-CRITICAL **: 10:02:10.552: g_variant_get_type_string: assertion 'value != NULL' failed

(io.elementary.greeter:39487): GLib-GIO-CRITICAL **: 10:02:10.552: g_settings_set_value: key 'font-name' in 'org.gnome.desktop.interface' expects type 's', but a GVariant of type '(null)' was given

(io.elementary.greeter:39487): GLib-CRITICAL **: 10:02:10.552: g_variant_unref: assertion 'value != NULL' failed

(io.elementary.greeter:39487): GLib-CRITICAL **: 10:02:10.553: g_variant_new_string: assertion 'string != NULL' failed

(io.elementary.greeter:39487): GLib-CRITICAL **: 10:02:10.553: g_variant_ref_sink: assertion 'value != NULL' failed

(io.elementary.greeter:39487): GLib-CRITICAL **: 10:02:10.553: g_variant_ref_sink: assertion 'value != NULL' failed

(io.elementary.greeter:39487): GLib-GIO-CRITICAL **: 10:02:10.553: g_settings_schema_key_type_check: assertion 'value != NULL' failed

(io.elementary.greeter:39487): GLib-CRITICAL **: 10:02:10.553: g_variant_get_type_string: assertion 'value != NULL' failed

(io.elementary.greeter:39487): GLib-GIO-CRITICAL **: 10:02:10.553: g_settings_set_value: key 'monospace-font-name' in 'org.gnome.desktop.interface' expects type 's', but a GVariant of type '(null)' was given

(io.elementary.greeter:39487): GLib-CRITICAL **: 10:02:10.553: g_variant_unref: assertion 'value != NULL' failed

stale

zeebok · 2024-05-23T15:42:51Z

@lenemter There is a conflict to resolve now

zeebok · 2024-06-24T14:52:13Z

I am seeing the same compiler errors as the checks

src/Application.vala

tintou

a few nits

tintou · 2024-07-04T07:02:33Z

src/Application.vala


    Gtk.init (ref args);

    var window = new Greeter.MainWindow ();
    window.show_all ();

+    try {
+        portals = new Greeter.SubprocessSupervisor ({"/usr/libexec/xdg-desktop-portal"});


It is unclear to me why you need to spawn this?

tintou · 2024-07-04T07:03:27Z

src/Application.vala

+    });
+
+    try {
+        settings_daemon = new Greeter.SubprocessSupervisor ({"io.elementary.settings-daemon"});


Also unclear?

tintou · 2024-07-04T07:04:38Z

src/Cards/UserCard.vala

+            changed_properties.lookup ("PrefersColorScheme", "i", out prefers_color_scheme);
+            greeter_act.prefers_color_scheme = prefers_color_scheme;


Suggested change

changed_properties.lookup ("PrefersColorScheme", "i", out prefers_color_scheme);

greeter_act.prefers_color_scheme = prefers_color_scheme;

if (changed_properties.lookup ("PrefersColorScheme", "i", out prefers_color_scheme)) {

greeter_act.prefers_color_scheme = prefers_color_scheme;

}

Support dark mode

155ccb5

This was referenced Sep 2, 2023

Use dark style in greeter session elementary/wingpanel#499

Draft

Expose prefer dark schedule settings elementary/settings-daemon#85

Merged

lenemter added 4 commits October 21, 2023 13:38

Merge branch 'master' into lenemter/support-dark-mode

0e29187

Merge branch 'master' into lenemter/support-dark-mode

55f4d46

Avoid loading lighdm_act many times

bb95147

Fix lint

dada4a6

lenemter marked this pull request as ready for review January 27, 2024 12:05

lenemter requested a review from a team January 27, 2024 12:05

Merge branch 'master' into lenemter/support-dark-mode

7c5fcfe

danirabbit reviewed Jan 30, 2024

View reviewed changes

src/PantheonAccountsServicePlugin.vala Outdated Show resolved Hide resolved

Simplify last coordinates

b01ac4b

lenemter requested a review from danirabbit January 30, 2024 09:22

danirabbit previously approved these changes Jan 30, 2024

View reviewed changes

lenemter added 2 commits February 3, 2024 19:34

Fix settings

825b0a3

Merge branch 'master' into lenemter/support-dark-mode

6da7d4a

lenemter requested a review from danirabbit February 5, 2024 03:02

lenemter and others added 3 commits February 8, 2024 14:19

Merge branch 'master' into lenemter/support-dark-mode

29e535d

Merge branch 'master' into lenemter/support-dark-mode

2844ca2

Remove bad merge line

5d93138

lenemter mentioned this pull request Feb 14, 2024

Fix criticals #705

Merged

danirabbit added 2 commits March 10, 2024 14:20

Merge branch 'master' into lenemter/support-dark-mode

a6a63aa

Merge branch 'master' into lenemter/support-dark-mode

6c5998d

zeebok added 3 commits April 2, 2024 22:23

Merge branch 'master' into lenemter/support-dark-mode

0ec938f

Merge branch 'master' into lenemter/support-dark-mode

e279b07

Merge branch 'master' into lenemter/support-dark-mode

971d451

lenemter and others added 2 commits June 23, 2024 22:56

Merge branch 'master' into lenemter/support-dark-mode

6b34a15

Merge branch 'master' into lenemter/support-dark-mode

d37ade6

zeebok reviewed Jul 3, 2024

View reviewed changes

src/Application.vala Outdated Show resolved Hide resolved

Fix build

143814f

tintou requested changes Jul 4, 2024

View reviewed changes

lenemter marked this pull request as draft July 4, 2024 16:01

zeebok added 2 commits August 5, 2024 23:08

Merge branch 'master' into lenemter/support-dark-mode

7a1eeec

Merge branch 'master' into lenemter/support-dark-mode

831e723

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support dark mode #684

Support dark mode #684

lenemter commented Sep 2, 2023 •

edited

Loading

BAProductions commented Sep 2, 2023

danirabbit left a comment

danirabbit commented Jan 31, 2024

lenemter commented Jan 31, 2024 •

edited

Loading

lenemter commented Feb 3, 2024

danirabbit commented Feb 5, 2024 •

edited

Loading

lenemter commented Feb 8, 2024

danirabbit commented Feb 13, 2024 •

edited

Loading

zeebok commented May 23, 2024

zeebok commented Jun 24, 2024

tintou left a comment

tintou Jul 4, 2024

tintou Jul 4, 2024

tintou Jul 4, 2024

		changed_properties.lookup ("PrefersColorScheme", "i", out prefers_color_scheme);
		greeter_act.prefers_color_scheme = prefers_color_scheme;

Support dark mode #684

Are you sure you want to change the base?

Support dark mode #684

Conversation

lenemter commented Sep 2, 2023 • edited Loading

BAProductions commented Sep 2, 2023

danirabbit left a comment

Choose a reason for hiding this comment

danirabbit commented Jan 31, 2024

lenemter commented Jan 31, 2024 • edited Loading

lenemter commented Feb 3, 2024

danirabbit commented Feb 5, 2024 • edited Loading

lenemter commented Feb 8, 2024

danirabbit commented Feb 13, 2024 • edited Loading

zeebok commented May 23, 2024

zeebok commented Jun 24, 2024

tintou left a comment

Choose a reason for hiding this comment

tintou Jul 4, 2024

Choose a reason for hiding this comment

tintou Jul 4, 2024

Choose a reason for hiding this comment

tintou Jul 4, 2024

Choose a reason for hiding this comment

lenemter commented Sep 2, 2023 •

edited

Loading

lenemter commented Jan 31, 2024 •

edited

Loading

danirabbit commented Feb 5, 2024 •

edited

Loading

danirabbit commented Feb 13, 2024 •

edited

Loading